Adding wolfram group of commands to gurkbot #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onerandomusername
requested changes
Jan 8, 2022
There was a problem hiding this comment.
Welcome, and thank you for your first pull to gurkbot!
Given how the wolfram api works, I have a few requests. I would also like to point out the app_id is the secret, so we shouldn't be using our request as the image link.
Additionally, a user can expose the hosting provider's location, IP, and other information by searching 'Where am I'.
To mitigate these impacts, we can provide an ip and location with query parameters.
On the good side of things, thank you for putting the token in .env-example, and not once did I receive an error saying the application timed out or did not reply.
onerandomusername
added
area: commands
Akarys42
previously requested changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to the issue #53
Things added:
1) A wolfram cog in the fun folder in cogs
2) A wolfram group of commands which , for now, consists of the image command
Things changed:
1) wolfram_emoji added to constants.py
2) Tokens class for the app_id for the Wolfram API
image command:
> Fetches an image url based on a user query
> This url is embedded and sent to the respective channel it was called in
Note:
The wolfram API requires a token which has to be provided for in the .env as:
WOLFRAM_TOKEN="<token_here>"