feat: add more strict function definitions

[garusis]

Currently addQueryToURL returns a union type forcing to always do some kind of type narrowing to the answer, even when is not necessary taking into account that in runtime the output will always have the same type of the input.

Before:

function onlyAcceptUrl(input: URL){...}
function onlyAcceptString(input: string){...}

const result = addQueryToURL(new URL('https://example.com/api?id=1'), {
     page: '2',
})
onlyAcceptURL(result instanceof URL ? result : new URL(result))
// OR
onlyAcceptURL(result as URL)

const result2 = addQueryToURL('https://example.com/api?id=1', {
     page: '2',
})
onlyAcceptURL(typeof result2 === "string" ? result : result.toString())
// OR
onlyAcceptURL(result2 as string)

Now:

function onlyAcceptUrl(input: URL){...}
function onlyAcceptString(input: string){...}

const result = addQueryToURL(new URL('https://example.com/api?id=1'), {
     page: '2',
})
onlyAcceptURL(result)

const result2 = addQueryToURL('https://example.com/api?id=1', {
     page: '2',
})
onlyAcceptURL(result2)

[gustavoguichard]

Hey @garusis ! I love your contribution and in fact I already had a branch to do the same: main...fix-addquerytourl-return-type
I prefer to use the generic approach instead of function overload although I'd love to have you as a contributor of this project.
Would you mind changing it to generic and then we can publish it?

[gustavoguichard]

@all-contributors please add @garusis for code, and bug.

[allcontributors]

@gustavoguichard

I've put up a pull request to add @garusis! 🎉