Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: An extension to add support for imagemin images compression #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JayaKrishnaNamburu
Copy link
Contributor

No description provided.

@guybedford
Copy link
Owner

Looks good!

Can we get a test? Also can we make it work as a single image task for parallel functioning?

@JayaKrishnaNamburu
Copy link
Contributor Author

Sure, i will add the tests now 👍

@guybedford
Copy link
Owner

I wonder if it would be faster to just use the base libraries directly?

Eg https://github.com/imagemin/jpegtran-bin has a native binary behind it.

Perhaps we need a Chomp task for downloading and caching binaries then using them.....

@JayaKrishnaNamburu
Copy link
Contributor Author

I wonder if it would be faster to just use the base libraries directly?

Eg https://github.com/imagemin/jpegtran-bin has a native binary behind it.

Perhaps we need a Chomp task for downloading and caching binaries then using them.....

Yes, but they work best for individual tasks maybe. Like for jpeg's alone something like that. imagemin gives flexibility to work with all types at once. Maybe just like an another option 😄

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title An extension to add support for imagemin images compression WIP: An extension to add support for imagemin images compression Mar 18, 2022
@guybedford
Copy link
Owner

@JayaKrishnaNamburu it still just chains the operations on the same image though, which could be handled by a command line process in 1/10th of the time (Node.js has 100ms startup time cost). I think that would be the better approach eventually, have put down the idea of arbitrary executable URLs in guybedford/chomp#96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants