Quick attempt for splitting builds #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with a quick rollup config change + search & replace for shimMode -> self.SHIM_MODE Size for non-wasm integrated build in main: 9160 New non-wasm polyfill build size: 9019 New non-wasm shim build size: 8805 Interestingly enough there were more savings for shim mode than polyfill mode. But in both the savings are not very significant (<0.5kb). It could be possible to get more savings with some more careful optimization, but that's out of scope for this current PR.
|
Good to know, yes the polyfill footprint is the one to optimize. The best savings likely start with removing unneeded features (eg if you don't need to polyfill import maps we can remove all that stuff), but this likely becomes more important once (a) the baseline progresses or (b) there are new features being polyfilled that require overhead. Definitely worth keeping an eye and reassesing the status here. |
|
@lewisl9029 I'm reconsidering picking this up again to integrate #269 and having separate development and production builds. This is a useful comparison, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with a quick rollup config change + search & replace for shimMode -> self.SHIM_MODE
Size for non-wasm integrated build in main:
9160
New non-wasm polyfill build size:
9019
New non-wasm shim build size:
8805
Interestingly enough there were more savings for shim mode than polyfill mode. But in both the savings are not very significant (<0.5kb).
It could be possible to get more savings with some more careful optimization, but that's out of scope for this current PR.
Feel free to close once you've had a chance to take a look!