Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache and load registry #11

Merged
merged 2 commits into from
Jul 16, 2024
Merged

cache and load registry #11

merged 2 commits into from
Jul 16, 2024

Conversation

guybuk
Copy link
Owner

@guybuk guybuk commented Jul 16, 2024

Currently users can't use their own data categories (and cache/load methods). Instead, we:

  1. deprecate the DataCategory enum (since enums can't be expanded on)
  2. replace separate cache and load methods with a DataIO class. The idea is that saving and loading is very similar in essence (e.g. np.load/np.save) and with a class, users don't have to use very similar code in two different sections of the repo.
  3. Allow registering DataIO classes

guybuk added 2 commits July 14, 2024 17:04
- replaced them with a registry, which allows users to decorate custom functions and register their own
@guybuk guybuk marked this pull request as ready for review July 16, 2024 07:13
@guybuk guybuk merged commit ce71e13 into main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant