Skip to content

Commit

Permalink
Added missing fallback to GET
Browse files Browse the repository at this point in the history
Closes #167
  • Loading branch information
GrahamCampbell committed Aug 14, 2021
1 parent 21e931a commit 8f8992f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Serializer.php
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected function createRequest(CommandInterface $command)
// If command does not specify a template, assume the client's base URL.
if (null === $operation->getUri()) {
return new Request(
$operation->getHttpMethod(),
$operation->getHttpMethod() ?: 'GET',

This comment has been minimized.

Copy link
@GuyPaddock

GuyPaddock Nov 30, 2022

@GrahamCampbell This is the wrong spot for this... why not fix it in the defaults, as I wrote up in #167? Also, why no validation and no test for this?

$this->description->getBaseUri()
);
}
Expand Down

0 comments on commit 8f8992f

Please sign in to comment.