Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pygrb injection plot formatting fixes #52

Merged
merged 6 commits into from
Jun 16, 2020

Conversation

a-r-williamson
Copy link
Contributor

@a-r-williamson a-r-williamson commented Apr 23, 2020

There have been a few plotting bugs in need of squashing.

  • Make the colormap used for FAP colour scale colour-blind friendly and uniform perception. The colormap to use here appears to be cividis.
  • Attempt to fix the odd y-axis scaling that sometimes happens in injection plots.
  • Duplicate injection plots but with one version having missed injections at front, another with found at front
  • Ensure plot titles fit in figure bounds
  • Consider changing marker size in injection recovery plots for easier consumption

Copy link
Contributor

@pannarale pannarale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @a-r-williamson. It looks all fine. Will wait for the other 3 tasks to be done before merging.

@a-r-williamson a-r-williamson marked this pull request as draft April 24, 2020 09:54
@a-r-williamson
Copy link
Contributor Author

Yeah I need to test things properly too, it's not ready.

@titodalcanton
Copy link
Contributor

Hi @a-r-williamson, you could make the found-missed plot look like the one from the all-sky search for consistency (gwastro/pycbc#3218).

@a-r-williamson
Copy link
Contributor Author

This PR is to address #54

@a-r-williamson a-r-williamson changed the title Pygrb plot improvements Pygrb injection plot formatting fixes Apr 27, 2020
@a-r-williamson a-r-williamson force-pushed the pygrb_plot_improvements branch from 1bb746a to b8a3c08 Compare April 29, 2020 11:58
@a-r-williamson a-r-williamson force-pushed the pygrb_plot_improvements branch from b8a3c08 to 1b25c04 Compare April 30, 2020 14:39
@a-r-williamson
Copy link
Contributor Author

Rebased to master after bugfix in #56.

@a-r-williamson
Copy link
Contributor Author

As of now the injection recovery plots have significant changes to their appearance. The changes so far incorporate:

Together these changes turn...
image
...into...
image
The alternate version of this plot with found injections foregrounded is...
image

@pannarale
Copy link
Contributor

Nice, you spared me some future work @a-r-williamson!

@a-r-williamson
Copy link
Contributor Author

Small change made to order the filled circles by their FAP, like in all-sky search. The above two examples now become:
image
image

@a-r-williamson a-r-williamson marked this pull request as ready for review April 30, 2020 16:09
@a-r-williamson
Copy link
Contributor Author

This will need corresponding changes to the result page, which I'll make next. I believe all required changes will be in pycbc_make_grb_summary_page and within pycbc.results, so if approved this can be merged.

@a-r-williamson
Copy link
Contributor Author

Hi @pannarale, are you happy with how this is now?

@pannarale pannarale merged commit 4ad4b17 into gwastro:master Jun 16, 2020
@a-r-williamson a-r-williamson deleted the pygrb_plot_improvements branch June 16, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants