Allow PhenomXPHM options in laldict for v23 release branch #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* disable git lfs post-clone hook checks for lalsuite-extra * Also in basic-tests.yml
GarethCabournDavies
approved these changes
May 28, 2024
tdent
approved these changes
May 28, 2024
There was a problem hiding this comment.
If this is tested to work to do the thing we want in the short term, then approve.
Clearly the general strategy is not great but this is a broader problem of how to deal with the laldict interface in a more systematic way involving dozen of other possible parameters.
GarethCabournDavies
added a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Jul 24, 2024
) * Add 2 Phenom parameters that we need here for XPHM * Also need it here * FIx previous * disable git lfs post-clone hook checks for lalsuite-extra (gwastro#4755) * disable git lfs post-clone hook checks for lalsuite-extra * Also in basic-tests.yml --------- Co-authored-by: Gareth S Cabourn Davies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some important options for generating XPHM, which we need to support in the v23 release branch. There is a related PR (#4728), which tries to deal with the more general case, though there are concerns about lalsimulation's naming and how to predict that.
For now, I hardcode the necessary values, and leave a more general discussion for the main branch.
For the wider audience: BE CAREFUL WITH PHENOMXPHM! There is a rare failure mode where it will produce
infs (or other garbage) for long waveforms. This appears to be a bug with the multi-banding, which is on by default.I have tested this on one of these failure modes via a HDF input file, with the new option (avoiding multi-banding) I get sane output, without I get infs.