Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live singles fits plot names #4856

Conversation

GarethCabournDavies
Copy link
Contributor

Fix an annoyance in the naming of single significance plots for each IFO.

Also remove unused options

Standard information about the request

This is a minor fix
This change affects the live search
This change changes naming of live automatically produced plots

This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Contents

Change to use a daily singles fit filename format which uses IFOs, and then replaces that string for the single-ifo plots

Testing performed

Supervisor script still runs and makes plots with the appropriate name (once the config is updated as appropriate)

  • The author of this pull request confirms they will adhere to the code of conduct

Copy link
Contributor

@maxtrevor maxtrevor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all make sense, approving. That said, merging is currently blocked by CI issues

@titodalcanton
Copy link
Contributor

Please rebase on master to pick up #4855 and get the tests to pass.

@GarethCabournDavies GarethCabournDavies merged commit d9f728d into gwastro:master Aug 21, 2024
30 checks passed
@GarethCabournDavies GarethCabournDavies deleted the supervise_fit_coeff_dq_files branch August 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants