Add dq fitting to Live supervised fitting script #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
requested changes
Sep 11, 2024
maxtrevor
force-pushed
the
idq_trigger_fits
branch
from
303beed
to
d37185d
Compare
Comment on lines
+126
to
+127
| ifo_group.create_dataset('observing_livetime', data=livetime) | ||
| ifo_group.create_dataset('dq_flag_livetime', data=flagged_time) |
There was a problem hiding this comment.
I've found the issue with using HFile, this line uses hasattr('dtytpe') to check it is is a numpy array, which is needed to allow the fletcher32 keyword to be set.
However numpy number-types have dtype attributes as well. The options are either:
- change that line to use
isinstance(data, np.ndarray)instead [should work] - change this line to give dq_flag_livetime as an attribute [will work]
- Change this line to cast dq_flag_livetime as a numpy array before saving it [I think this will work, and allow this dataset to be checksummed]
There was a problem hiding this comment.
I think changing that line to use isinstance(data, np.ndarray) is the cleanest fix. It will also prevent this issue from arising again in the future for some other unsuspecting student.
GarethCabournDavies
approved these changes
Sep 13, 2024
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR completes the statistic upgrade for PyCBC Live by allowing the daily supervised fitting script to produce DQ trigger rate files for use with the DQ reweighting statistic
This is a new feature.
This change primarily affects the live search.
Two files are modified which are used in the offline search; they are bin/all_sky_search/pycbc_bin_templates and bin/plotting/pycbc_plot_dq_flag_likelihood . In both cases, the change should not cause any functional difference.
This changes the scientific output of the live search when the DQ reweighted stat is being used, otherwise it does not make a difference.
This also makes a number of changes to bin/live/pycbc_live_supervise_collated_trigger_fits beyond just adding the dq fitting process. Changes include moving the code used to calculate the original date of replay data into its own function, code style improvements, removing unused imports, changing variable names to be less ambiguous, etc.
Two new scripts are added to the bin/live/ folder, these are used for performing the dq fitting. The first gathers dq statistical information for a day of data, the second combines the information from multiple days an produces a statistic file to be ingested by the search.
After this is merged, we should be ready to create a new release branch for the live analysis.