Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions to use modern versions #4867

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

spxiwh
Copy link
Contributor

@spxiwh spxiwh commented Sep 9, 2024

As stated in #4865, a github workflow tool seems to have a security risk. dependabot doesn't seem capable of rebasing itself, so I open a new PR here with the same change.

@spxiwh spxiwh requested a review from ahnitz September 9, 2024 15:56
ahnitz
ahnitz previously approved these changes Sep 9, 2024
Copy link
Member

@ahnitz ahnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass, go ahead and merge

@titodalcanton
Copy link
Contributor

I think there was a failure in the previous PR actually. I noticed PyPMC did this: pypmc/pypmc@0065288 Maybe we need something similar to that.

@ahnitz ahnitz dismissed their stale review September 9, 2024 15:59

See Tito's comment

@ahnitz
Copy link
Member

ahnitz commented Sep 9, 2024

@titodalcanton Looks like you hit it on the nail based on the CI error.

@titodalcanton titodalcanton changed the title Update download artefact Update upload and download artefact actions from v2 to v4 Sep 12, 2024
@titodalcanton
Copy link
Contributor

I took the liberty of using this PR to also fix an error I started seeing today on all tests:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

I also included a fix for yet another deprecation warning that had been showing up for a while.

@titodalcanton titodalcanton changed the title Update upload and download artefact actions from v2 to v4 Update GitHub actions to use modern versions Sep 12, 2024
@titodalcanton
Copy link
Contributor

Ok, this is getting somewhere. A couple more fixes and I think this will be approvable.

@ahnitz ahnitz merged commit c8a9105 into gwastro:master Sep 12, 2024
30 checks passed
@spxiwh spxiwh deleted the pr_dl_artefact branch September 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants