Bugfix for live fits #4881
Merged
Bugfix for live fits #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| all_ifos = controls['ifos'].split() | ||
| active_ifos = get_active_ifos(merged_triggers) | ||
| active_ifos = [ifo for ifo in active_ifos if ifo in all_ifos] |
There was a problem hiding this comment.
I think here we are looking at removing any IFOs which are in the trigger file but not in the config file? That may be worth commenting, as I got confused for a minute
GarethCabournDavies
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a bug where if an ifo had no data for an entire day, it would cause an error in the daily supervised fitting. This fixes that bug.
This affects only the PyCBC Live search, not offline.