Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in altitude support and simplify adding detector function #4884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Sep 19, 2024

  • Adds in the ability to set the altitude angles for custom detectors
  • Simplify detector class, use lal only for its detector location information rather than the response value itself. This makes it easier to provide consistent metadata between custom and lal-builtin detectors
  • Simplify the add detector on the earth function (use matrix multiplication operator, make the rotations clearer / more obvious / start rotations from simpler form of the basic arm response)

Todo

  • update unittest to include both use of custom detector and crosscheck response matrix calculation against builtin lal value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant