Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in input files check #4885

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pannarale
Copy link
Contributor

@pannarale pannarale commented Sep 19, 2024

Fix bug when checking user choices for input files.

Standard information about the request

This is a: bug fix

This change affects: PyGRB

This change changes: result presentation

Motivation

The --offsource-file option was set to required=True (as it should be), but then only one out of --offsource-file, --onsource-file and --found-missed-file was allowed to be passed, so the user could not process the onsource or the found/missed injections.

Contents

The test is now ensuring that --onsource-file and --found-missed-file are not simultaneously given by the user.

Testing performed

The change was tried in a full (re)post-post processing of this box giving this new webpage.

  • The author of this pull request confirms they will adhere to the code of conduct

@MarcoCusinato MarcoCusinato merged commit 152014b into gwastro:master Sep 24, 2024
30 checks passed
@pannarale pannarale deleted the pygrb_page_tables_bug branch September 24, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyGRB PyGRB development
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants