Fix bug in fetching injection group param #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnitz
approved these changes
Nov 4, 2024
|
@tdent You'll need to rebase from the PR I just merged to address the macos build issues. |
* try macos latest version * move to update macos on build as well Co-authored-by: Alex Nitz <[email protected]>
pannarale
pushed a commit
to pannarale/pycbc
that referenced
this pull request
Nov 7, 2024
* Fix bug in fetching injection group param * try macos latest version (gwastro#4922) (gwastro#4926) * try macos latest version * move to update macos on build as well Co-authored-by: Alex Nitz <[email protected]> --------- Co-authored-by: Alex Nitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The injection param fetching has an obvious bug in a branch which I am guessing has never been used .. see the change
This is a: bug fix
This change affects: plotting utility code currently not used in offline search
This change changes: result presentation / plotting
This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: not have any effect other than improving ability to retrieve injection params
Testing performed
Works to retrieve the
injections/tcdataset.