Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Mac and Linux tests #4925

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/basic-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,28 @@ jobs:
strategy:
max-parallel: 60
matrix:
os: [ubuntu-20.04]
os: [ubuntu-latest, macos-latest]
python-version: ['3.9', '3.10', '3.11', '3.12']
test-type: [unittest, search, docs]
steps:
- uses: conda-incubator/setup-miniconda@v3
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: installing system packages
run: |
sudo apt-get -o Acquire::Retries=3 update
sudo apt-get -o Acquire::Retries=3 install *fftw3* mpi intel-mkl* git-lfs graphviz
conda install fftw mpi git-lfs graphviz gsl openssl openmpi
pip install "tox<4.0.0" pip setuptools --upgrade
- name: installing macosx packages
if: matrix.os == 'macos-latest'
run: |
conda install -c conda-forge lapack==3.9.0
- name: installing ubuntu packages
if: matrix.os == 'ubuntu-latest'
run: |
conda install -c conda-forge lapack==3.6.1
- name: installing auxiliary data files
run: |
GIT_LFS_SKIP_SMUDGE=1 git clone https://git.ligo.org/lscsoft/lalsuite-extra
Expand Down
28 changes: 0 additions & 28 deletions .github/workflows/mac-test.yml

This file was deleted.

26 changes: 0 additions & 26 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ deps =
[testenv]
allowlist_externals = bash
passenv=LAL_DATA_PATH
conda_deps=openssl
conda_channels=conda-forge
platform = lin: linux
mac: darwin

# This test should run on almost anybody's environment
[testenv:py-unittest]
Expand All @@ -28,16 +24,6 @@ deps =
; Needed for `BBHx` package to work with PyCBC
git+https://github.com/titodalcanton/BBHx.git@py39-and-cleanup; sys_platform == 'linux'
git+https://github.com/gwastro/BBHX-waveform-model.git; sys_platform == 'linux'
conda_deps=
mysqlclient
lin: gcc_linux-64>=12.2.0
lin: gxx_linux-64>=12.2.0
; mac doesn't work, need fix
; mac: clang_osx-64
; mac: clangxx_osx-64
gsl
lapack==3.6.1
conda_channels=conda-forge
setenv =
; Tell the linker to look for shared libs inside the temporary Conda env.
; Needed to build BBHx's wheel, whick links to LAPACK.
Expand Down Expand Up @@ -73,18 +59,6 @@ deps =
; Needed for `BBHx` package to work with PyCBC
git+https://github.com/titodalcanton/BBHx.git@py39-and-cleanup; sys_platform == 'linux'
git+https://github.com/gwastro/BBHX-waveform-model.git; sys_platform == 'linux'
conda_deps=
mysqlclient
lin: gcc_linux-64>=12.2.0
lin: gxx_linux-64>=12.2.0
; mac doesn't work, need fix
; mac: clang_osx-64
; mac: clangxx_osx-64
binutils_linux-64>=2.39
gsl
lapack==3.6.1
openmpi
conda_channels=conda-forge
setenv =
PYCBC_TEST_TYPE=docs
; Tell the linker to look for shared libs inside the temporary Conda env.
Expand Down
Loading