Replace GWTQuery with Elemental2 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes nothing in the output except for how it is produced, and ideally paves the way to more simply producing just the output we need for the website.
tbroyer
reviewed
Aug 9, 2024
niloc132
reviewed
Aug 9, 2024
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
| styleHomepage(); | ||
| } | ||
| }); | ||
| resizeHandler = Window.addResizeHandler(event -> styleHomepage()); |
There was a problem hiding this comment.
(far) future cleanup - use elemental here too.
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/highlight/JsHighlight.java
Outdated
Show resolved
Hide resolved
…yPoint.java Co-authored-by: Colin Alworth <[email protected]>
niloc132
reviewed
Aug 21, 2024
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
| mainTitle = subMenuItem.querySelector("a").textContent + " - " + selectedItem.textContent; | ||
| } else { | ||
| mainNavigationHref = Window.Location.getPath(); | ||
| mainTitle = isOverviewPage(mainNavigationHref) ? "Overview" : "Project"; |
There was a problem hiding this comment.
This looks like a change in behavior? I'm not necessarily opposed, but it does make reviewing this giant rewrite a little trickier.
There was a problem hiding this comment.
Yes, since the GQuery selectors are NPE-safe I had to add the if (selectedItem != null) check and then it felt weird to replicate the buggy behavior in the else branch 🤷
This should be the only behavior change though.
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/gwt/site/webapp/client/GWTProjectEntryPoint.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Colin Alworth <[email protected]>
Sounds good, thanks! |
|
Preview at https://www.gwtproject.org.vertispan.com/ (also includes gwtproject/gwt-site#366 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Gitter, GWTQuery breaks navigation when certain Chrome extensions are active.
This should also reduce the code size a bit.
Closes #11 -- all the changes are included here to make Elemental work.
Most functionality stays the same, page title for hompage changed, which makes this conflicted with #1
Fixes #5
Fixes #4