-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement node assembly and standardize identifiers #24
Conversation
I will test this now in practice to try to make a new build and will push fixes here. Until then, feel free to review/comment @cthoyt . |
|
||
if __name__ == "__main__": | ||
ReactomeProcessor.cli() | ||
WikipathwaysProcessor.cli() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way cli
is implemented somehow the second call here to WikipathwaysProcessor is never reached. @cthoyt if you know why, please push a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I don't know why this isn't working
This is basically working now. One thing I didn't figure out how to refactor best is the integration of node assembly with cached node generation from individual processors. Currently, |
Overall looks good. I think we should have started by keeping the prefix/id separate for each node. I made a comment on the code, but the operation of validating prefix/id pairs and canonicalizing them should be operations implemented in INDRA, right? Also, now we have the nice CI tests for code docs, we have to do all of them ;) |
The tests are erroring on GHA with |
I'm honestly not sure this much strict linting and mypy is productive, we need to be able to move on and focus on functionality. |
@cthoyt I'm not sure why this happens, I haven't used tox with pytest in this way before so am a bit lost. What would we need to change to avoid the "ModuleNotFoundError: No module named 'indra_cogex'" errors on GHA? See e.g., https://github.com/bgyori/indra_cogex/runs/2593007487?check_suite_focus=true. |
I thought the `__init__.py` wasn't required anymore but maybe it still is
This PR makes the following changes:
identifier
into two separatens
andid
parts to make conversions easier. Curies are created only when exporting Nodes and Relations. In another PR, the Neo4jClient will be adapted to these changes. Fixes Pathway sources should use INDRA-standard gene/protein IDs #22. Partially fixes Identifier standards need to be enforced when querying #23.