-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint Queries #186
Endpoint Queries #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good overall, I only have minor changes that I think you should look at. Otherwise, I have some suggestions that we should discuss if they make sense or not that we don't necessarily have to implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes requested, otherwise it's done.
Updated description with todo list |
This PR adds the REST API related to getting statements from graph databases based on various constraints
There are four endpoints added:
get_stmts_for_agent_type: Query Retrieves statements on agent type (subject/subject) as well as the agent name in text
get_stmts_for_source: Retrieves statements based on the source type (e.g "reach")
get_stmts_for_rel_type: Retrieves statements based on the statement type(e.g. "Phosphorylation")
get_statements_mix: A comprehensive endpoint that allows combined filtering by agent name, agent type, source type, and statement type.
Todo
In the
get_statements_mix
function:get_statements
agent_name
should beagent
and be either a tuple, which assumes (namespace, id) is provided, or a string, which assumes a name is provided.other_agent
andother_role
as optional parameters for second agent in query.