Migrate Rust app to async/await syntax #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dave,
I've been meaning to do this for months - this PR removes the extra logging dependency and rolls Hyper forward to 0.13 so we can use the newly stabilized async/await syntax, which I feel is an increase in code clarity. I also added
anyhow::Error
as in improvement overBox<dyn std::error::Error
to skirt around a few waywardunwrap()
s.The app appears to run properly. However, I was unable to build the acceptance test as-is and don't use Ruby so wasn't immediately clear on whether it's a me problem or a repo problem:
Admittedly, I spent about zero time debugging this issue. Could you let me know if I should be expected to follow the acceptance test readme as-is, or does a dependency need to bump? If it's on my end, I'll play with it until i can pass the tests locally.
Once this lands, I'll update the blogpost.