Choose pluck_script based on Redis version #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 13, 2023
houndci-bot
reviewed
Aug 14, 2023
houndci-bot
reviewed
Apr 21, 2024
houndci-bot
reviewed
Apr 21, 2024
|
@russointroitoa any updates on that PR ? |
Remove byebug and fix linting Fix line too long Add hashie dependency Mock RedisClient instead of Hashie Fix tests Fix comparison Fix indentation Remove redundant curr directory path Change constant name
russointroitoa
force-pushed
the
check_redis_version_for_lua_script
branch
from
69a3bb7
to
b3497cd
Compare
houndci-bot
reviewed
Sep 16, 2024
|
@ericproulx Sorry for the long delay. The problem should be fixed now. My updates involve:
|
|
@russointroitoa no worries thanks :) Probably in another PR, you could load the script initially in redis instead of always passing the raw version. I've seen this within the redlock gem that load the script if not present and use the Somehow, I don't know when the connection is established with Redis, but it could improve a little bit the network latency since you'll pass the SHA1 instead of the whole script every time. I could give it a try if would like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the updated LUA script coming from this PR uses commands available from Redis >= 6.2.0, with the following PR we select the old or new LUA script based on the Redis version