Allow client to verify certificate with NULL server name #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client only enforces name/ipaddr verification in verify_cert_chain if the server_name is not NULL
kazuho
reviewed
Apr 12, 2024
huitema
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the client always verifies the server name against the server's cert.
This change would allow the client to skip the name verification (as the server does) if a NULL server name is provided.
This would primarily be to allow the use of servers/clients on a local network without hostnames.
It would also be the first step to resolving this Picoquic issue: private-octopus/picoquic#1184