fix(NimBLEDevice): clear all before port_deinit to prevent crash #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(NimBLEDevice): clear all before port_deinit to prevent crash
12 tasks
|
Thanks!, LGTM |
|
@finger563 Looks like we have a new issue caused by this change, h2zero/NimBLE-Arduino#724. I may revert this and look for an alternative, thoughts? |
h2zero
added a commit
that referenced
this pull request
Oct 30, 2024
* General code cleanup * `NimBLEDevice::getInitialized` renamed to `NimBLEDevice::isInitialized`. * `NimBLEDevice::setPower` no longer takes the `esp_power_level_t` and `esp_ble_power_type_t`, instead only an integer value in dbm units is accepted. * `NimBLEDevice::setPower` now returns a bool value, true = success. * `NimBLEDevice::setMTU` now returns a bool value, true = success. * `NimBLEDevice::injectConfirmPIN` renamed to `NimBLEDevice::injectConfirmPasskey` to use Bluetooth naming. * Fixes crash if `NimBLEDevice::deinit` is called when the stack has not been initialized. * reverts #197 as it would cause a crash if when a NimBLEServer has a connection.
h2zero
added a commit
that referenced
this pull request
Oct 30, 2024
* General code cleanup * `NimBLEDevice::getInitialized` renamed to `NimBLEDevice::isInitialized`. * `NimBLEDevice::setPower` no longer takes the `esp_power_level_t` and `esp_ble_power_type_t`, instead only an integer value in dbm units is accepted. * `NimBLEDevice::setPower` now returns a bool value, true = success. * `NimBLEDevice::setMTU` now returns a bool value, true = success. * `NimBLEDevice::injectConfirmPIN` renamed to `NimBLEDevice::injectConfirmPasskey` to use Bluetooth naming. * Fixes crash if `NimBLEDevice::deinit` is called when the stack has not been initialized. * reverts #197 as it would cause a crash if when a NimBLEServer has a connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an upstream PR matching esp-cpp#3. Relevant info copied below:
Description
Update
NimBLEDevice::deinit()to run theclearAllblock (if true) before callingnimble_port_deinit()Motivation and Context
I found that running
NimBLEDevice::deinit(true)if I had a client created (as inespp::BleGattServer) would lead to a crash as the~NimBLEClient()would callble_npl_callout_deinit(), which would lead to a crash. Moving theclearAllblock to before thenimble_port_deinit()call does not result in a crash for the same code.How has this been tested?
Building and running in a separate project which was crashing before this change.
See example output here: esp-cpp/espp#325
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Small snippet of the coredump:
