EPAVin subclass to fetch data from epa's fueleconomy.gov #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ramodule imports)
Contributor
Author
|
This is in better shape now. It's not production code -- error handling is silly -- but the heuristics for looking things up in the epa database are coming along. |
…ort a couple more attributes, and apply some heuristics earlier for greater justice.
dankegel
changed the title
dankegel
changed the title
Contributor
Author
|
Well, the error handling is less silly now -- the prints are hidden behind a verbose mode -- and it handles 700 VIN's from local dealers plausibly well. It could use a review before merging, but it probably wouldn't hurt too much to merge as-is. |
…classing might be wrong approach.
Also: - Feverishly large set of regression fixes - Don't match I by itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet.
This isn't very efficient, and isn't complete, and for some reason fetches from fueleconomy.gov aren't being cached. Just putting it up here for feedback on the interface.