Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set activity started only if Column is main content #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Sep 20, 2021

If Column is supposed to be used as subcontent (e.g. in h5p/h5p-accordion#41), it should not call setActivityStarted() on its own but leave that to the parent content type (just like other compound content types do). Otherwise, the xAPI attempted statement may be triggered prematurely and report a wrong duration in the completed statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant