Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume slider to mute button #171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

camvrgs
Copy link

@camvrgs camvrgs commented Dec 28, 2020

Addresses Issue #160 , adds a vertical volume slider to the mute button, which updates the video volume level using setVolume (available in all handlers of H5P.Video).

@otacke
Copy link
Contributor

otacke commented Dec 29, 2020

@camvrgs Very cool addition! Thanks! I hope the H5P core team will find time to take a look at this pull request soon.

The one thing that they'll probably comment on is accessibility, as you can neither access the slider with the keyboard (you now have ) nor is it announced via readspeakers. You might want to check on YouTube how it's done there, maybe that's an option here as well.

@camvrgs
Copy link
Author

camvrgs commented Dec 31, 2020

@otacke Great suggestion, you're right that would make it more of a complete solution. I'll take another look, thanks!

@Nugatp
Copy link

Nugatp commented Jul 15, 2021

Hey everyone. Is this project inactive? It would be amazing if we could merge this!

@fudgepop01
Copy link

Hi! I came looking here after getting fed up with the lack of a slider while watching an assigned video at my university ahahah - what's odd to me is that the capability to adjust the volume is already there. There is clearly a video.setVolume(0 to 100) when I stepped through with the developer tools, but it's just inaccessible.

Technically I can just adjust the volume of my computer but that just seems cumbersome for a feature that is already theoretically available. Have the maintainers taken a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants