Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/captions-default-to-off #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rider-griffin
Copy link

This change applies a fix to the captions editor of interactive-video, in which leaving the "Default Text Track" empty forces the captions to be set to "Off" once the video is played. The incentive for this change is as follows:

  • Before this change, leaving the "Default Text Track" textbox empty would default the captions to the first text track in the tracks array. For example, if you had English as the first track and Spanish as the second, the captions would default to English if left empty, or even in the case "Off" was typed in to the text box
  • This has forced users to add an "empty" text track to their subtitles array in order to get the video to default to off, which is undesired.
  • The semantics have been changed so that the user can still type in a label they want the captions to default to, as long as it is in the tracks array. However, if they do not type in anything, it will default to "Off" automatically.

This issue is well documented in the h5p discussion forum, linked here. This change addresses the issues discussed and would assist many users requesting this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant