Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for check button #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yukhnevych
Copy link

@yukhnevych yukhnevych commented Jun 2, 2017

@icc this is the part of H5P.QuestionSet pull request.

@icc
Copy link
Member

icc commented Jun 23, 2017

Thanks for the pull request. I've created an issue for getting it merged in: HFP-1217

The following needs to be fixed before this can be merged in:

  1. Adding new fields to the top of an array in semantics.json require that all the translation files in language/ are updated, if not the labeling in the editor will be incorrect for those using the translations.
  2. The new field should us a conditional widget to hide the checkboxes used to disable the other buttons. This makes for a cleaner UI as changing the new checkbox always makes the other buttons hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants