Fix use of undirected broadcast in FreeBSD. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you bind to a specific interface's IP in FreeBSD, you cannot use INADDR_BROADCAST as your destination. While the L3 address will be 255.255.255.255, the L2 address will be that of the gateway. Instead, use a directed broadcast and set the sockopt IP_ONESBCAST to support turning the directed broadcast into an undirected broadcast on the given interface. Without this fix, MNDP listening works, but actually using MAC-Telnet to connect to devices does not.
|
I don't have a freebsd box to test with, but I trust that you have tested this and it is working. Does the non-broadcast/raw packet part work on freebsd also? (-n option in mactelnet) which uses bpf. |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you bind to a specific interface's IP in FreeBSD, you cannot use INADDR_BROADCAST as your destination. While the L3 address will be 255.255.255.255, the L2 address will be that of the gateway. Instead, use a directed broadcast and set the sockopt IP_ONESBCAST to support turning the directed broadcast into an undirected broadcast on the given interface.
Without this fix, MNDP listening works, but actually using MAC-Telnet to connect to devices does not.