-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clap-v4 support for hab
cli
#9330
Open
agadgil-progress
wants to merge
20
commits into
main
Choose a base branch
from
agadgil/hab-sup-clap4-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-habitat processing.
|
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
August 2, 2024 03:48
612cb36
to
9c7ee0e
Compare
CHEF-14734 |
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
August 14, 2024 08:01
d4f79d7
to
85003b9
Compare
Starting with some `cfg` trickery to make sure we continue to build old stuff. Very very experimental. Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
Initial skeleton for `hab pkg` command with Clap v4. This functionality gets enabled only with `v4` feature (off by default). Thus we continue to work with existing functionality. Signed-off-by: Abhijit Gadgil <[email protected]>
The command `hab pkg binds <PKG_IDENT>` runs and the outputs with `clap-v2` and `clap-v4` are comparable. Early still, but we can now implement more commands like this. Signed-off-by: Abhijit Gadgil <[email protected]>
- Initial implementation of `hab pkg binds` - Initial implementation of `hab pkg binlink` - Initial implementation of `hab pkg path` - Initial implementation of `hab pkg build` Signed-off-by: Abhijit Gadgil <[email protected]>
- Added `hab pkg config` command - Added `hab pkg env` command - Added `hab pkg hash` command - Added `hab pkg header` command - Added `hab pkg info` command - Added `hab pkg verify` command Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
Also fixed issue with building on macos due to `#[cfg(....)]` in `do_build`. Signed-off-by: Abhijit Gadgil <[email protected]>
Removed the `hab bldr job` from `main_v2` Signed-off-by: Abhijit Gadgil <[email protected]>
- Implemented `hab pkg channels` command - Implemented `hab pkg demote` command - Implemented `hab pkg dependencies` command - Implemented `hab pkg download` command - Implemented `hab pkg promote` command Also added an API in `PackageSetFile` to get `Vec<PackageSet>` from the `toml` file. Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
It should be possible to make either `v2` or `v4` feature as default. Initially when we were using `v4`, `v2` was also being used. Now `v4` can be opted in stand alone without `v2`. This reduces number of compiled packages by about 15. Signed-off-by: Abhijit Gadgil <[email protected]>
- `hab pkg exec` - `hab pkg export` - `hab pkg provides` - `hab pkg search` - `hab pkg sign` - `hab pkg upload` Signed-off-by: Abhijit Gadgil <[email protected]>
- Added `hab pkg install` - Added `hab pkg uninstall` Signed-off-by: Abhijit Gadgil <[email protected]>
1. Added Unit tests for `AuthToken` APIs we are using 2. Added Unit tests for `BldrUrl` APIs we are using 3. Added Unit tests for `PkgDownloadOptions` This covers unit tests for *new* logic we have written during the porting activities. Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
When exporting a package, if the given package does not exist in the specified channel (or default channel) we were unwrapping an error, rather than properly returning it. Signed-off-by: Abhijit Gadgil <[email protected]>
Signed-off-by: Abhijit Gadgil <[email protected]>
agadgil-progress
force-pushed
the
agadgil/hab-sup-clap4-support
branch
from
August 26, 2024 08:44
88721b2
to
bd42815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with some
cfg
trickery to make sure we continue to build old stuff. Very very experimental.