forked from KxSystems/pykx
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Values first approach #20
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
82d276d
Values first approach
cperezln 731d464
Test changed to check pd.values against implemented values. Values op…
cperezln db79521
Changed to property (as defined in pandas docs). documentation written
cperezln 213f65e
Changed values to property (as defined in pandas docs). values docume…
cperezln 7b15166
Undone Notebook metadata changes
cperezln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -353,6 +353,45 @@ | |
"tab.size" | ||
] | ||
}, | ||
{ | ||
"cell_type": "markdown", | ||
"id": "4023811f-0f23-4e4b-919c-c055b865d9d2", | ||
"metadata": {}, | ||
"source": [ | ||
"### Table.values\n", | ||
"Return a matricial representation of the DataFrame.\n", | ||
"\n", | ||
"Only the values in the DataFrame will be returned, the axes labels will be removed.\n", | ||
"\n", | ||
"**Returns:**\n", | ||
"\n", | ||
"| Type | Description |\n", | ||
"| :---------------: | :------------------------------------------------------------------- |\n", | ||
"| List | Rows of the table, each as a list. |" | ||
] | ||
}, | ||
{ | ||
"cell_type": "code", | ||
"execution_count": 2, | ||
"id": "a7843813-43fc-4920-acd9-6fd2dd50c32e", | ||
"metadata": {}, | ||
"outputs": [ | ||
{ | ||
"ename": "NameError", | ||
"evalue": "name 'tab' is not defined", | ||
"output_type": "error", | ||
"traceback": [ | ||
"\u001b[0;31m---------------------------------------------------------------------------\u001b[0m", | ||
"\u001b[0;31mNameError\u001b[0m Traceback (most recent call last)", | ||
"\u001b[0;32m/tmp/ipykernel_77428/394326152.py\u001b[0m in \u001b[0;36m<module>\u001b[0;34m\u001b[0m\n\u001b[0;32m----> 1\u001b[0;31m \u001b[0mtab\u001b[0m\u001b[0;34m.\u001b[0m\u001b[0mvalues\u001b[0m\u001b[0;34m\u001b[0m\u001b[0;34m\u001b[0m\u001b[0m\n\u001b[0m", | ||
"\u001b[0;31mNameError\u001b[0m: name 'tab' is not defined" | ||
] | ||
} | ||
], | ||
"source": [ | ||
"tab.values" | ||
] | ||
}, | ||
{ | ||
"cell_type": "markdown", | ||
"id": "2be2ece3", | ||
|
@@ -1287,7 +1326,9 @@ | |
{ | ||
"cell_type": "markdown", | ||
"id": "35062560", | ||
"metadata": {}, | ||
"metadata": { | ||
"scrolled": false | ||
}, | ||
"source": [ | ||
"Remove the `z` and `w` columns from the table and return them." | ||
] | ||
|
@@ -1296,9 +1337,7 @@ | |
"cell_type": "code", | ||
"execution_count": null, | ||
"id": "a46189b2", | ||
"metadata": { | ||
"scrolled": false | ||
}, | ||
"metadata": {}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you redo this change? |
||
"outputs": [], | ||
"source": [ | ||
"display(tab.head())\n", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,6 +134,11 @@ def shape(self): | |
@property | ||
def size(self): | ||
return q('{count[x] * count[cols x]}', self) | ||
|
||
@property | ||
def values(self): | ||
tab = self | ||
return q('value peach', tab) | ||
|
||
@api_return | ||
def mean(self, axis: int = 0, numeric_only: bool = False): | ||
|
@@ -257,6 +262,7 @@ def sum(self, axis=0, skipna=True, numeric_only=False, min_count=0): | |
min_count | ||
), cols) | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you redo this change? |
||
def agg(self, func, axis=0, *args, **kwargs): # noqa: C901 | ||
if 'KeyedTable' in str(type(self)): | ||
raise NotImplementedError("'agg' method not presently supported for KeyedTable") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you redo this change, pls