-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementation of values #28
Added implementation of values #28
Conversation
…timized (to value peach)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the implementation is on the right track, but there are a couple of aspects that need to be checked. Mainly:
- Does the q session run with multithreading enabled on PyKX? I will ask the devs and get back to you so you can decide what to do next.
- The tests need a bit of work. I think a specific case with null values would be helpful to see if they are handled properly.
- The assertion itself it's a bit tricky, so feel free to iterate over my suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now 👍
}, | ||
{ | ||
"cell_type": "code", | ||
"execution_count": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of execution_count
should be null, like in the others code cells
Feature
What does this change introduce?
An implementation of the
values
function: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.values.htmlThis is intended to be a 1:1 implementation of the
values
function from pandas.General
src/pykx/pykx.q
andsrc/pykx/reimporter.py
src/pykx/util.py
logic which is used for environment variable.zip
been updatedCode
Testing
Documentation
.md
file associated with it been created?mkdocs.yml