-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add samples from other vehicles #48
Comments
Be careful I've seen data linked to vehicle registered id and security code for the radio. |
@oncleben31 if you have spotted anything extra, can you add checks on https://github.com/hacf-fr/renault-api/blob/develop/tests/model/test_kamereon.py#L52 ? |
@epenet why do you say VIN has to start with VF1AAAAA555777 ? |
@TheSleepySlee this is simply to ensure private data is not added to the GIT repository by mistake. |
ok makes sense, I thought you were stating that VIN had 5 letters then 6 numbers after VF1, which is not always the case. I will try to add my data. There is no documentation. Should assume same working as with Pyze? |
There is not yet a CLI (only an API) and I am working on the documentation. If in doubt, you can get the trace from PyZE and add it here... |
@TheSleepySlee you can now use the renault-api CLI to generate traces.
|
It would be great to get samples from more vehicles and from extra functionalities.
Vehicles:
Data:
Action:
Errors:
To add a fixture:
renault-api CLI
:test/fixtures/kamereon
folder (vehicles
orvehicle_data
)REG-
, that the vin starts withVF1AAAA
and that the radio code is equal to1234
.Note:
registration number
,vin
andradio code
are currently the only keys which need to be obfuscated. If you feel that extra data should be automatically obfuscated, then please tweaktests/model/test_kamereon.py
and add a separate PR.The text was updated successfully, but these errors were encountered: