Add Dacia Duster fixtures #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
force-pushed
the
duster-fixtures
branch
from
76de091
to
3b72b6b
Compare
epenet
commented
Nov 18, 2021
Comment on lines
+33
to
+43
| "duster.1.json": { | ||
| "get_brand_label": "RENAULT", | ||
| "get_energy_code": "ESS", | ||
| "get_model_code": "XJD1SU", | ||
| "get_model_label": "NEW DUSTER", | ||
| "reports_charging_power_in_watts": False, | ||
| "uses_electricity": False, | ||
| "uses_fuel": True, | ||
| "supports-hvac-status": True, | ||
| "supports-location": True, | ||
| }, |
There was a problem hiding this comment.
@FRSTR can you please confirm that it is a fuel-only vehicle, and these specs are correct?
There was a problem hiding this comment.
Yes, this car uses petrol only. The fields look correct, though I'm not sure what get_energy_code stands for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48, #157, #404
cc @FRSTR