Fix badge date 248 #278
Merged
Fix badge date 248 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added to .gitignore * added a file testdb_seed * removed reseting db from docker_script because this is handled in docker-compose-dev NOTE: docker-compose.yml is not currently used and will not reset or seed the database. Just use docker-compose-dev.yml for now.
requests: 2.18.4 > 2.22.0 SQLAlchemy 1.1.14 > 1.3.3 PyJWT 1.4.2 > 1.7.1 urllib3 1.22 > 1.25.2
alembic 0.9.6 > 1.0.10 flask-sqlalchemy 2.3.2 > 2.4.0 pyscopg2 2.7.5 > psycopg2-binary 2.7.5 sqlalchemy-utils 0.33.5 > 0.33.11 werkzeug 0.14.1 > 0.15.4 Specifying a jwt decode algorithm avoids a deprication warning that would have been introduced from these version update commits.w
requirements.txt is generated by pipfile so fixing pipfile should have been the first step. This commit should fix the outdated libraries that had security issues.
Using the db table Year which stores a single value (what the current year is) the badges will display the current year.
codenprose
approved these changes
May 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status:
Deploy link
Description
badges are labeled with current year
Using the db table Year which stores a single value (what the current year is) the badges will display the current year.
Note: there may be a need to store these badges in the database rather than calculate them on the fly. The way this is designed will likely produce undesired results when switching the program from one year to the next however for demo purposes, the current method should work.
Related issues: #248
Todos
Screenshots