Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add darktile support #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SirCipherz
Copy link

i added support for https://github.com/liamg/darktile

Copy link
Owner

@hackerb9 hackerb9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is dark tile?

Why does it write to a file named "code"?
I'd there a simpler way to test for "darktile"?

Copy link
Owner

@hackerb9 hackerb9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your work, but I cannot accept this merge request.

If darktile is a sixel compatible terminal emulator, then it should respond with a '4' when lsix asks if it supports sixels.

Also, while ps works for an individual user, it should not be necessary for every user of lsix to fork an external command each time lsix is run just to detect sixel support. If darktile has technical limitations in how it responds, as yaft did, then we would support it using the same method: by checking the TERM environment variable.

@hackerb9
Copy link
Owner

hackerb9 commented Aug 9, 2021

Would you be willing to file a bug report with the darktile project to let them know it is not working with lsix? Thanks!

@SirCipherz
Copy link
Author

thanks for your review hackerb9, i removed the creation of the code file which only was a debug file, the method the project is currently using for yaft doesn't work because the TERM variable for darktile is xterm-256colors, the method i'm using is the best i found yet.

@hackerb9
Copy link
Owner

thanks for your review hackerb9, i removed the creation of the code file which only was a debug file, the method the project is currently using for yaft doesn't work because the TERM variable for darktile is xterm-256colors, the method i'm using is the best i found yet.

Unfortunately, it seems like this is something the authors of darktile will have to address. Have you filed a bug report with that project? If not, please do so so that programs like lsix can automatically detect that darktile has sixel support.

In the meantime, here is an ugly environment variable kludge based on your method that may help you. You can add it to your login script (e.g., .bash_profile):

if [[ "$(ps -o comm= -p "$(($(ps -o ppid= -p "$(($(ps -o sid= -p "$$")))")))")" == darktile ]]; then
   export LSIX_FORCE_SIXEL_SUPPORT=yuck
fi

It's not the right solution, but you can try it if you don't get any response from the darktile developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants