-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Connect Lighthouse CI to database on dev #108
base: dev
Are you sure you want to change the base?
Conversation
When the Docker configuration was changed from using volumes to referring to actual folder paths on the server, the data we had earlier has been effectively nuked. The secrets are updated, and our LHCI will start gathering new data from now on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. I had some questions before approving.
- How is it able to connect to the database on noodlebar? You are only using the local docker name for the database so I dont know how it works.
- We also have to setup it to connect to the local s3 server the same way so it can load images.
- You can remove all the FEIDE_ and MATRIX_ environment variables as those have been set to optional.
- Can we fix it so it stops failing, why is it failing?
I will create a separate issue for fixing the lighthouse issues. Some of the ones on the auth page are quite useful, like why is the title missing? Also we can then create a CSP on that same branch |
Right, I am dumb. I assume we dont want to expose the database, so this needs to run on noodlebar so it has access to the services. Will need to move it to the self-hosted runner there. Hopefully, there's an option to force using the dev server and not anything else. I think GH actions is set up there already? |
This reverts commit c9f6ea8.
…pace-ntnu/website-next into fix/lhci-use-local-build
Lighthouse CI is the least documented tool I've ever interacted with. After finding what environment variable needs to be set by looking at the source code, LHCI can't connect to Chrome. I'm not looking anymore into this, if you want to look at it, feel free to |
The lighthouse CI GitHub Actions workflow is now connected to the database running on our dev server.
I have not found any solution which could "reuse" our already running build on the dev server, but if you manage to find something that could work, feel free to change the PR.
The workflow runs only on pull requests, so it runs the absolute minimum amount of times, therefore consuming less of our minutes available for workflows.