Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1086/security issues verified #1521

Merged

Conversation

bkmorgan3
Copy link
Member

@bkmorgan3 bkmorgan3 commented Sep 25, 2023

Fixes #1086

What changes did you make and why did you make them ?

  • Added the verify cookie middleware before Create, Update, Delete actions for Projects and Events

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b bkmorgan3-1086/security-issues-verified development
git pull https://github.com/bkmorgan3/VRMS.git 1086/security-issues-verified

@bkmorgan3 bkmorgan3 requested a review from trillium September 26, 2023 01:31
@bkmorgan3
Copy link
Member Author

@spiteless I had to put the Secret back in, because the build was failing without it. That might have to be its own ticket.

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Reveiwed in VRMS call, great job

@bkmorgan3 bkmorgan3 merged commit 3556bae into hackforla:development Oct 10, 2023
5 checks passed
trillium added a commit to trillium/VRMS that referenced this pull request Mar 4, 2024
* 1086/security issues verified (hackforla#1521)

* add verification check before mutations

* remove log

* cleanup unused imports

* update tests

* update Update and Read tests

* move vble to env file

* undo secret removal

---------

Co-authored-by: Brad <[email protected]>
Co-authored-by: Trillium S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Issues
2 participants