Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newuser to mui #1744

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

angela-lee1
Copy link
Member

Fixes #1720

What changes did you make and why did you make them ?

  • Replace standard HTML components with applicable MUI components.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

[image](
Screenshot 2024-09-14 at 5 56 12 PM
)

Visuals after changes are applied

[image](
Screenshot 2024-09-14 at 6 30 52 PM
)

@bkmorgan3 bkmorgan3 self-requested a review September 16, 2024 17:53
@bkmorgan3
Copy link
Member

@awlFCCamp did you delete the bot instructions for checking out this branch?

@angela-lee1
Copy link
Member Author

angela-lee1 commented Sep 16, 2024

@bkmorgan3 I don't think I did. Are you referring to one of the GitHub Actions being deleted? I only modified and pushed one file(NewUser.jsx). didn't do anything to .github.

@angela-lee1
Copy link
Member Author

angela-lee1 commented Sep 16, 2024

@bkmorgan3 You were concerned my "Add Pull Request Instructions ..." didn't get run. In one of the yml files we need to change uses: actions/upload-artifact@v2 to uses: actions/upload-artifact@v3
Hope I am correct here. @trillium can you chime in? Thank you!

jbubar
jbubar previously requested changes Sep 17, 2024
Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awlFCCamp Requesting we keep the Css in the css files. can you use the class name

@trillium
Copy link
Member

trillium commented Sep 24, 2024

@bkmorgan3 You were concerned my "Add Pull Request Instructions ..." didn't get run. In one of the yml files we need to change uses: actions/upload-artifact@v2 to uses: actions/upload-artifact@v3 Hope I am correct here. @trillium can you chime in? Thank you!

Yeah, hopefully the github action change will resolve this

@bkmorgan3
Copy link
Member

@trillium No, no. Its just new UI I am not used to seeing. I just needed to click View Command Line Instructions under the tests module. All good

@trillium
Copy link
Member

trillium commented Sep 24, 2024

Ah, gottcha. Regardless, we've currently got some errors in our github toolchain

@nora-zajzon nora-zajzon dismissed jbubar’s stale review September 24, 2024 14:51

We ended up agreeing that inline styling is fine.

Copy link
Member

@nora-zajzon nora-zajzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website looks the same as the screenshots she provided. All html are now mui. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/NewUser.js
5 participants