-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newuser to mui #1744
base: development
Are you sure you want to change the base?
Update newuser to mui #1744
Conversation
@awlFCCamp did you delete the bot instructions for checking out this branch? |
@bkmorgan3 I don't think I did. Are you referring to one of the GitHub Actions being deleted? I only modified and pushed one file(NewUser.jsx). didn't do anything to .github. |
@bkmorgan3 You were concerned my "Add Pull Request Instructions ..." didn't get run. In one of the yml files we need to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awlFCCamp Requesting we keep the Css in the css files. can you use the class name
Yeah, hopefully the github action change will resolve this |
@trillium No, no. Its just new UI I am not used to seeing. I just needed to click View Command Line Instructions under the tests module. All good |
Ah, gottcha. Regardless, we've currently got some errors in our github toolchain |
We ended up agreeing that inline styling is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Website looks the same as the screenshots she provided. All html are now mui. Looks good!
update branch
Fixes #1720
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
[image](
)
Visuals after changes are applied
[image](
)