Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: filter on projects-check page differs from filter on projects page #4834

Closed
5 tasks
roslynwythe opened this issue Jun 14, 2023 · 2 comments
Closed
5 tasks
Assignees
Labels
Complexity: Medium ER Emergent Request p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jun 14, 2023

Emergent Requirement - Problem

Two problems have been noted with the appearance of the filters on the projects-check page. In both cases the correct appearance can be observed on the projects page.

Details

  1. The filters on the projects-check page should appear to the left of the project cards, however they are instead center-aligned and the project cards appear below the filters. For the correct appearance see the screenshot of the projects page below.
  2. On the projects-check page, on page load the number of displayed filters is limited to eight, however no "View All" link is displayed even if more than eight filters exist.

Note that if more than 8 categores exist in both the Technology and Language groups, it should be possible to view all the filters in both groups at once.

Appearance of filters (incorrect) on Projects-check page

image

Appearance of filters (correct) on Projects Page

image

Issue you discovered this emergent requirement in

Date discovered

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@

What happens if this is not addressed

The projects-check page is not usable since it does not allow all testing of all filter categories.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  1. Update projects-check.html to incorporate recent changes made to projects.html so that the unintended differences between the projects-check and projects page are resolved. This approach was taken in fix filter on projects-check page  #4850
  2. Update projects-check.html to use the same HTML and JavaScript as projects.html, then modify the common JavaScript code to implement distinct filters in the projects-check page based on testing the current page URL. This approach is examined in Refactor HTML and JavaScript so projects and projects-check pages can share the same files #4960
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: 0.25pt Can be done in 0.5 to 1.5 hours role: front end Tasks for front end developers p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly Complexity: Medium and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Jun 14, 2023
@roslynwythe roslynwythe self-assigned this Jun 18, 2023
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe
Copy link
Member Author

roslynwythe commented Jun 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium ER Emergent Request p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

No branches or pull requests

3 participants