Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "good second issue" from CONTRIBUTING.md Section 2.1 #5588

Closed
4 of 5 tasks
Tracked by #4506
roslynwythe opened this issue Sep 26, 2023 · 3 comments · Fixed by #5658
Closed
4 of 5 tasks
Tracked by #4506

Remove "good second issue" from CONTRIBUTING.md Section 2.1 #5588

roslynwythe opened this issue Sep 26, 2023 · 3 comments · Fixed by #5658
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 26, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to remove references to "good second issue" from CONTRIBUTING.md in order to avoid confusion, since we are no longer creating issues with the label `Complexity: good second issue'.

Action Items

  • In your local IDE, navigate to CONTRIBUTING.md and locate Section 2.1
  • Replace
2. `Complexity: Good second issue`
  *  Self-assign an issue with the `Complexity: Good second issue` label. 
  * Complete steps in [**2.7 Working on an issue**](#27-working-on-an-issue) to create a solution for the issue
  * Complete steps in [**3.1 How to make a pull request**](#31-how-to-make-a-pull-request) to get your solution reviewed by the `website-merge` team
  * Once your pull request is merged, you can work on your next issue.

Progress through issues with increasing complexity in the following order:
  1. Good first issue
  2. Good second issue
  4. Small 
  5. Medium 
  6. Large

with

2. Repeat #1 with a new `good first issue`

Progress through issues with increasing complexity in the following order:
  1. Good first issue (x2)
  2. Small 
  3. Medium 
  4. Large
  5. Extra Large
  • Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL. Also store the test URL for use in a later step:
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/bonniewolfe/website/blob/issue-branch-1234/CONTRIBUTING.md)

  • Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.
For Reviewers: Do not review changes locally, rather review changes at [REPLACE WITH TEST URL]

For Merge Team

Resources/Instructions

CONTRIBUTING.md
Getting started with writing and formatting on GitHub

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing Ignore: Test Issue was created for testing purposes only labels Sep 26, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. ready for dev lead Issues that tech leads or merge team members need to follow up on Ignore: Test Issue was created for testing purposes only Complexity: Missing size: missing labels Sep 26, 2023
@roslynwythe roslynwythe changed the title test Remove "good second issue" from CONTRIBUTING.md Section 2.1 Sep 26, 2023
@anjolaaoluwa anjolaaoluwa added this to the 08. Team workflow milestone Oct 1, 2023
@robertnjenga robertnjenga self-assigned this Oct 3, 2023
@robertnjenga
Copy link
Member

Availability: 10a-2p
ETA: 10/3/2023

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hi @robertnjenga, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

4 participants