-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified CONTRIBUTING.md #5658
modified CONTRIBUTING.md #5658
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Availability: Weekdays |
Availability: Weekday afternoons/evenings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertnjenga nice work on this issue. Branches are setup correctly, code changes are as mentioned in the issue and clean. The changes are reflecting in the test link provided. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertnjenga ,
Thanks for taking up this issue. You correctly stated what changes were mad, why they were made, and you linked to the updated template on your forked repo. It was a little hard to read through the "What" and the "Why" sections at first due to the formatting. The correct changes were made in the template and everything else looks good. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertnjenga — good job with this issue so far! The branching is set up correctly, the corresponding issue is linked, the change of updating step 2 and the progression outlined in the CONTRIBUTING.md
document has been made exactly as requested, and this change is reflected in your branch of the document.
Before I can merge this issue, there's just one change that should be made: can you remove the details and summary tags in the Screenshots section of your PR and instead state that no visual changes have been made? Doing this will help keep our documentation clean and easy to use (by indicating at a quick glance that there were no visual changes).
Once the PR has been correctly edited, I can merge this PR to the codebase; everything else is looking good so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertnjenga — thank you for making the edit in your PR! It looks good to me and everything else had stayed the same from the last review.
Thank you for taking up and completing this issue! 🙌🏼
Fixes #5588
What changes did you make?
Complexity: Good second issue
Complexity: Good second issue
label.website-merge
teamProgress through issues with increasing complexity in the following order:
good first issue
Progress through issues with increasing complexity in the following order:
Why did you make the changes (we will use this info to test)?
For Reviewers:
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes have been made.