Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace label in design-system-audit--text-elements.md #7603

Closed
15 tasks done
Tracked by #7602
ExperimentsInHonesty opened this issue Oct 20, 2024 · 2 comments · Fixed by #7748
Closed
15 tasks done
Tracked by #7602

Replace label in design-system-audit--text-elements.md #7603

ExperimentsInHonesty opened this issue Oct 20, 2024 · 2 comments · Fixed by #7748
Assignees
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Oct 20, 2024

Overview

We need to change the ready for label on the design-system-audit--text-elements.md issue template so that the merge team can handle more of the issue reviews.

Action Items

  • Open the files /.github/ISSUE_TEMPLATE/design-system-audit--text-elements.md
  • In the following text, add ready for merge team label
 labels: 'Complexity: Missing, Feature Missing, good first issue, role: design, size: 
   0.25pt' 
  • Push your issue branch to your fork of the website repository, as described in Section 3.1.a of CONTRIBUTING doc, for example: git push --set-upstream origin test-update-labels-1234

  • The response from the push command will include the URL for creating a pull request. Copy/Paste the URL for creating the Pull Request for later.

  • Browse to your fork of the website repository and click Settings

    Screenshot of Repository Settings

    image

  • Change the default branch to the new issue branch

    Screenshot of Default Branch Setting

    image

  • Further down on the settings page under Features, check the Issues checkbox

    Screenshot of Issues Checkbox

    image

  • From the Issues page, click "New Issue" then locate the template updated by your issue, and click "Get Started" to open the issue template.

  • Copy the URL of the issue creation page and save for later use.

  • Verify the appearance of the issue template.

  • Complete the Pull Request process by visiting the URL saved from the push command.

  • In the PR copy/paste this text immediately before the section "Screenshots of Proposed Changes Of The Website"

 ### For Reviewers
- Use this URL to check the updated issue template: [INSERT URL of issue creation page]
  • Replace the text in the square brackets (as well as the square brackets) with the URL of the updated issue template in your fork of the repository
  • Submit your pull request with your changes for review
  • After PR is merged, be sure to follow the steps above to change your default branch back to gh-pages and to disable Issues feature

Resources/Instructions

For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/.github/ISSUE_TEMPLATE/design-system-audit--text-elements.md?plain=1

@HackforLABot HackforLABot added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Oct 20, 2024
@ExperimentsInHonesty ExperimentsInHonesty added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Oct 20, 2024
@mchait18 mchait18 self-assigned this Nov 19, 2024
@mchait18 mchait18 moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Nov 19, 2024
@HackforLABot
Copy link
Contributor

HackforLABot commented Nov 19, 2024

Hi @mchait18, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: M-F 9:00-3:00 EST
ii. ETA: 11/20/24

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@mchait18
Copy link
Member

mchait18 commented Nov 19, 2024

I'm confused about this instruction - Image.
There is no label called, 'ready for dev lead' in this text. Do you mean to change the label further down in the file, here?

Image

This was resolved in the meeting last night

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

3 participants