-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace label in design system audit page #7748
Replace label in design system audit page #7748
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mchait18 Thank you for taking on this issue.
Things that went well
- The title and description are great
- The branch is correct
- The issue is linked correctly
Few things that need to be fixed
- The url is broken sends me to a 404 page.
- The screenshots are not showing properly.
After those are done I am more than happy to take another review on this for approval.
I've corrected the above suggestions and am ready for a re-review. Thanks |
Review
|
Hi @dcotelessa -
Please add yourself as a reviewer and submit these comments as a review. Thanks! |
I removed the screenshot info. Can you please submit as a review so this can be merged? Thanks |
Review ETA: 11/25/2024 Monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job working on this issue, @mchait18 !
- Availability and ETA are provided in the original issue
- The branch you made the change on is correct
- The original issue number is linked
- The change you made is accurate, the corresponding labels appear in the updated issue template
- The CodeQL Alerts are checked
Things to improve:
- Keep the
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
for your corresponding answerNo visual changes to the website
Reminder:
- Complete the following action item from the original issue:
- After PR is merged, be sure to follow the steps above to change your default branch back to
gh-pages
and to disable theIssues
feature
- After PR is merged, be sure to follow the steps above to change your default branch back to
Thank you for your contribution.
This is what it says to do in the Note - <!-- Notes:
|
Hey @daras-cu, You mentioned last night that you'd merge this issue. Thanks so much :) |
Fixes #7603
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
For Reviewers