Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace label in design system audit page #7748

Merged

Conversation

mchait18
Copy link
Member

@mchait18 mchait18 commented Nov 20, 2024

Fixes #7603

What changes did you make?

  • I added the label 'ready for merge team' to the design-system-audit--text-elements.md file

Why did you make the changes (we will use this info to test)?

  • This addition is so that the merge team can handle more of the issue reviews.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

  • No visual changes to the website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b mchait18-replace-label-in-design-7603 gh-pages
git pull https://github.com/mchait18/website.git replace-label-in-design-7603

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours labels Nov 20, 2024
@codyyjxn codyyjxn self-requested a review November 21, 2024 01:45
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mchait18 Thank you for taking on this issue.

Things that went well

  • The title and description are great
  • The branch is correct
  • The issue is linked correctly

Few things that need to be fixed

  • The url is broken sends me to a 404 page.
  • The screenshots are not showing properly.

After those are done I am more than happy to take another review on this for approval.

@mchait18
Copy link
Member Author

@mchait18 Thank you for taking on this issue.

Things that went well

  • The title and description are great
  • The branch is correct
  • The issue is linked correctly

Few things that need to be fixed

  • The url is broken sends me to a 404 page.
  • The screenshots are not showing properly.

After those are done I am more than happy to take another review on this for approval.

I've corrected the above suggestions and am ready for a re-review. Thanks

@mchait18 mchait18 requested a review from codyyjxn November 22, 2024 03:48
@dcotelessa
Copy link
Member

Review

  • Title and description look good
  • Branch correct
  • The issue is linked
  • URL is fixed
  • Do we need to keep screenshots info? (Noted the "no visual changes necessary" under the "Visuals before changes are applied"

@t-will-gillis
Copy link
Member

Hi @dcotelessa -

Review

  • Title and description look good
  • Branch correct
  • The issue is linked
  • URL is fixed
  • Do we need to keep screenshots info? (Noted the "no visual changes necessary" under the "Visuals before changes are applied"

Please add yourself as a reviewer and submit these comments as a review. Thanks!

@mchait18
Copy link
Member Author

Review

  • Title and description look good
  • Branch correct
  • The issue is linked
  • URL is fixed
  • Do we need to keep screenshots info? (Noted the "no visual changes necessary" under the "Visuals before changes are applied"

I removed the screenshot info. Can you please submit as a review so this can be merged? Thanks

@siyunfeng siyunfeng self-requested a review November 26, 2024 02:44
@siyunfeng
Copy link
Member

Review ETA: 11/25/2024 Monday
Availability: 6-10 PM Weekdays (EDT)

Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job working on this issue, @mchait18 !

  • Availability and ETA are provided in the original issue
  • The branch you made the change on is correct
  • The original issue number is linked
  • The change you made is accurate, the corresponding labels appear in the updated issue template
  • The CodeQL Alerts are checked

Things to improve:

  • Keep the Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes) for your corresponding answer No visual changes to the website

Reminder:

  • Complete the following action item from the original issue:
    • After PR is merged, be sure to follow the steps above to change your default branch back to gh-pages and to disable the Issues feature

Thank you for your contribution.

@mchait18
Copy link
Member Author

Great job working on this issue, @mchait18 !

  • Availability and ETA are provided in the original issue
  • The branch you made the change on is correct
  • The original issue number is linked
  • The change you made is accurate, the corresponding labels appear in the updated issue template
  • The CodeQL Alerts are checked

Things to improve:

  • Keep the Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes) for your corresponding answer No visual changes to the website

Reminder:

  • Complete the following action item from the original issue:

    • After PR is merged, be sure to follow the steps above to change your default branch back to gh-pages and to disable the Issues feature

Thank you for your contribution.

This is what it says to do in the Note - <!-- Notes:

  • If there are no visual changes to the website, delete all of the script below and replace with "- No visual changes to the website"
    -->

@mchait18
Copy link
Member Author

Hey @daras-cu, You mentioned last night that you'd merge this issue. Thanks so much :)

@t-will-gillis t-will-gillis merged commit 3d3f0f7 into hackforla:gh-pages Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging this pull request may close these issues.

Replace label in design-system-audit--text-elements.md
5 participants