Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated js behind projects-check page to accept tools as an array or a string #5025

Merged
merged 1 commit into from
Jul 19, 2023
Merged

updated js behind projects-check page to accept tools as an array or a string #5025

merged 1 commit into from
Jul 19, 2023

Conversation

roslynwythe
Copy link
Member

Fixes #4861

What changes did you make?

  • Updated js to accept tools as a comma separated string or an array

Why did you make the changes (we will use this info to test)?

  • The code updates were made so the code will work now (with tools as a comma-separated string) and also later (after tools is changed to an array)

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b roslynwythe-refactor-current-projects-check-4861 gh-pages
git pull https://github.com/roslynwythe/website.git refactor-current-projects-check-4861

@github-actions github-actions bot added role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 19, 2023
@roslynwythe roslynwythe changed the title updated js to accept tools as a comma separated string or an array updated js behind projects-check page to accept tools as an array or a string Jul 19, 2023
@ronaldpaek
Copy link
Member

ronaldpaek commented Jul 19, 2023 •
edited
Loading

CleanShot 2023-07-18 at 23 33 56@2x CleanShot 2023-07-18 at 23 34 13@2x CleanShot 2023-07-18 at 23 34 27@2x
  • Looks good to me, I updated the file, and it is still outputting correctly and not throwing an error.

@ronaldpaek ronaldpaek self-requested a review July 19, 2023 06:36
ronaldpaek
ronaldpaek approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is rendering correctly for me.

@t-will-gillis t-will-gillis merged commit cf23ef8 into hackforla:gh-pages Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldpaek ronaldpaek ronaldpaek approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor current-projects-check file to fix any formatting issue with new tools data format
3 participants
@roslynwythe @ronaldpaek @t-will-gillis