Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed tools items format #5123

Merged
merged 1 commit into from
Aug 9, 2023
Merged

changed tools items format #5123

merged 1 commit into from
Aug 9, 2023

Conversation

Vinny02
Copy link
Contributor

@Vinny02 Vinny02 commented Jul 31, 2023

Fixes #4801

What changes did you make?

  • The filter menu on the projects-check page requires modification to incorporate a "Tools" dropdown

Why did you make the changes (we will use this info to test)?

  • Changed the format for better visual clarity and to be consistent with the rest of the page.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No changes to site

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Vinny02-refactor-tools-data-4801 gh-pages
git pull https://github.com/Vinny02/website.git refactor-tools-data-4801

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 31, 2023
@wongstephen wongstephen self-requested a review August 2, 2023 19:04
@wongstephen
Copy link
Member

Availability 8/2 12pm - 5pm
ETA 8/2 EOD

Copy link
Member

@wongstephen wongstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vinny02

Great job on the first issue. You documented the changes correctly.

For the pull request comments, I recommend paraphrasing the description from the issue for clarity. Such as 'The filter menu on the projects-check page requires modification to incorporate a "Tools" dropdown.'

In addition, I do not believe it is necessary to add a screenshot as there are no visual changes to the website.

I can confirm the changes are correct and visually accurate when ran in my local environment. The card is hidden (maybe because the project is marked complete) but can be found at https://www.hackforla.org/projects/civic-tech-structure.

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vinny02 — going through PRs and I noticed a couple things that should be addressed and edited before this gets merged and closed:

  • The 'Why' section of your PR should be a bit more descriptive, more within the context of the issue itself. The Overview in the linked issue contextualizes the reason for this change, so I would edit this section with a quick blurb about why this needs to be in a list format. @wongstephen also provided a great example above!
  • I also agree with @wongstephen that this issue doesn't quite need a screenshot, but if you do provide a screenshot (for this issue and future ones), please screenshot the corresponding page on the website and not the Markdown file; the screenshot of what the user sees would be more useful to document.

Everything else is looking good so far (branching, linked issue, change itself) — just the documentation on the PR itself needs changes.

@Vinny02
Copy link
Contributor Author

Vinny02 commented Aug 7, 2023

Fixed! I used your suggestion for this one @wongstephen, and I'll follow your recommended strategy to paraphrase the issue in my future PRs. Thank you for the assistance as well @adrianang.

@Vinny02 Vinny02 requested a review from adrianang August 7, 2023 01:12
Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vinny02 — the PR looks good to me! The branching is set up correctly, the corresponding issue is linked, and the requested change was made correctly. Your branch is also showing up on my local environment through Docker and the Civic Tech Structure project visually and functionally remains unchanged.

Thank you for editing the message in your PR and for taking up this issue! 🙌🏼

@adrianang adrianang merged commit ffef3c1 into hackforla:gh-pages Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for civic-tech-structure.md
3 participants