Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Food oasis .md file refactored #5133

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Food oasis .md file refactored #5133

merged 1 commit into from
Aug 6, 2023

Conversation

awellsbiz
Copy link
Member

@awellsbiz awellsbiz commented Aug 3, 2023 •
edited
Loading

Fixes #4805

What changes did you make?

  • Changed tools data for food-oasis.md file from a string to list

Why did you make the changes (we will use this info to test)?

  • To include a dropdown for 'Tools' for the filter menu on the 'projects-check' page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b awellsbiz-food-oasis-tools-refactor-4805 gh-pages
git pull https://github.com/awellsbiz/website.git food-oasis-tools-refactor-4805

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Aug 3, 2023
@awellsbiz awellsbiz changed the title Food oasis .md file refcatored Food oasis .md file refactored Aug 3, 2023
@evanhesketh evanhesketh self-requested a review August 3, 2023 19:33
@evanhesketh
Copy link
Member

Availability: Aug 4, 10am-12pm pst
ETA: 08/04 EOD

@steven-positive-tran
Copy link
Member

Availability: 6-12pm pst
ETA: 08/03 EOD

@steven-positive-tran steven-positive-tran self-requested a review August 4, 2023 00:34
steven-positive-tran
steven-positive-tran approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@steven-positive-tran steven-positive-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches look from your fork to the main gh-pages, works on my device, and code changes seem in line with the issues that need to be addressed.

Looks good and thank you for taking up this issue.

evanhesketh
evanhesketh reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@evanhesketh evanhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted by the previous reviewer, branching is done correctly, issue is linked, the changes appear correctly in the browser, and the changes address the issue.
Please consider adding before/after screenshots of the website to your pull request to help reviewers visualize the changes you have made. Otherwise, great work!

@awellsbiz
Copy link
Member Author

Sounds good! Thanks for the review

adrianang
adrianang approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @awellsbiz — the branching is set up correctly, the corresponding issue has been linked to, and the requested change of refactoring the Tools into a list for Food Oasis has been made exactly as asked in the issue. In testing your branch on my local environment through Docker, the views for Food Oasis do not appear to be visually or functionally affected, as expected.

Good job figuring out the workflow from your previous PR; this PR is looking a lot cleaner in the commit history now! One thing that I would say is that your PR submissions should either include a photo if there is a visual change, or not have the image section at all, instead of having broken photo links; something to keep in mind for your next PR(s).

Thank you for taking up this issue! 🙌🏼

@adrianang adrianang merged commit f3f36d3 into hackforla:gh-pages Aug 6, 2023
@awellsbiz
Copy link
Member Author

awellsbiz commented Aug 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanhesketh evanhesketh evanhesketh left review comments

@steven-positive-tran steven-positive-tran steven-positive-tran approved these changes

@adrianang adrianang adrianang approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for food-oasis.md
4 participants
@awellsbiz @evanhesketh @steven-positive-tran @adrianang