-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update move-closed-issues.yaml #5574
Update move-closed-issues.yaml #5574
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 6 PM 9/30/23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing issue with "role: back end/devOps" wasn't move to the "Done" column.
Hi @aramattamara Thanks for your comment! FYI Looking at your "Action" logs, I believe that you need to update Line 10: change to '@v4', e.g. uses: actions/checkout@v4 Otherwise, it looks like you have everything set up correctly so I think these are the only edits needed. (In case you are wondering, both issues are being sorted to the "QA" column for a different reason than this action.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rechecked the 'Token' variable, and everything is working perfectly
✅ Looks good to me. Nice work @t-will-gillis
Review ETA: 9/28/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @t-will-gillis the changes on line 10 on the yaml file are done correctly so great job on this.
Fixes #5492
What changes did you make?
actions/checkout@v3
-->actions/checkout@v4
Why did you make the changes (we will use this info to test)?
Links to test branch
Note to PR Reviewers
The process for testing GHAs is different from procedures described in the
CONTRIBUTING.md
document. You will want to have an environment set up in your local repo and test the GHAs on the desktop.First, review the following wiki pages Hack for LA's GitHub Actions and follow the "Mini Guide".
To continue creating your testing environment, go to your local repo on the desktop and create a new branch for testing:
For testing this specific action you will need to make these changes to
.github/workflows/move-closed-issues.yaml
:uses: actions/checkout@v4
Additional steps needed to successfully test this action:
If the bot moves the issue with "role: front end" to the "QA column", and also moves the issue with "role: back end/devOps" to the "Done" column, then the test was successful.