Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update move-closed-issues.yaml #5574

Merged

Conversation

t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Sep 24, 2023

Fixes #5492

What changes did you make?

  • Updated actions/checkout@v3 --> actions/checkout@v4
  • Tested to confirm the GHA functions as expected with update
  • Testing was successful- see below. OK to update

Why did you make the changes (we will use this info to test)?

  • Change made to confirm the Dependabot recommended version updates for compatibility with existing automation

Links to test branch

Note to PR Reviewers

  • The process for testing GHAs is different from procedures described in the CONTRIBUTING.md document. You will want to have an environment set up in your local repo and test the GHAs on the desktop.

  • First, review the following wiki pages Hack for LA's GitHub Actions and follow the "Mini Guide".

    • Pay close attention especially to Steps 6 & 7.
    • Note in Step 6: When you create your Project Board, be sure to name it (or rename it if needed) "Project Board"
    • Note in Step 7: It is best practice to give your secret an expiration date.
    • Note in Step 7 also: when you are creating your own token, do not give your token the same name that you see in the yaml file. In other words, do not give your token the same name as HfLA's token, otherwise unexpected behavior may result. Any other name is OK (for example, TEST_TOKEN).
  • To continue creating your testing environment, go to your local repo on the desktop and create a new branch for testing:

    • From your "gh-pages" branch, make sure you are synced to HfLA.
    • Select the "gh-pages" button, enter a name for your test branch (such as "test-ghas-for-pr-review"), then select "Create branch". You will make edits and test from here.
    • Next, go to "Settings" on the upper right, scroll down to "Default branch", and select the button with the arrows to switch you default branch to another branch.
    • Find your newly created branch and select it, then "Update", then "I understand, update the default branch".
    • Important- when you are done testing you will want to repeat these steps to reselect "gh-pages" as your default branch, and then you can delete the test branch.
    • Now, when you make edits to the "website" on your repo you will only affect the new branch.
  • For testing this specific action you will need to make these changes to .github/workflows/move-closed-issues.yaml:

    • Line 10: change to '@v4', e.g. uses: actions/checkout@v4
    • Line 24: change to reference your token, e.g. token: ${{ secrets.TEST_TOKEN }}
  • Additional steps needed to successfully test this action:

    • Set up "Labels" if you have not done so already: select "Issues" from your repo, then "New Issue", then choose any issue with "Get Started" on the right, then on the right click on the gear next to "Labels". You will need to add all of the following labels if you have not already: "Complexity: Missing", "Feature Missing", "role missing", "size: missing", "role: front end","role: back end/devOps" .From "Labels", click on "Edit labels" , then "New label", and add each label exactly as shown, without the quotes.
    • Now select "Issues" again, "New issue" , then at "Blank Issue Template" select "Get started".
    • If you did the previous steps correctly, four labels will be present under "Labels". Select the gear, then add "role: front end" and create issue.
    • Repeat to create a second issue, except this time add the "role: back end/devOps" label.
    • If the two issues you just created are not added to your "Project Board", do so.
    • Close the first issue, then the second issue.
  • If the bot moves the issue with "role: front end" to the "QA column", and also moves the issue with "role: back end/devOps" to the "Done" column, then the test was successful.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-dependabot-update-5492 gh-pages
git pull https://github.com/t-will-gillis/website.git dependabot-update-5492

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Sep 24, 2023
@t-will-gillis t-will-gillis removed the Draft Issue is still in the process of being created label Sep 24, 2023
@github-actions github-actions bot added the Draft Issue is still in the process of being created label Sep 27, 2023
@aramattamara
Copy link
Member

aramattamara commented Sep 27, 2023

Review ETA: 6 PM 9/30/23
Availability: 2 PM-6 PM Friday

Copy link
Member

@aramattamara aramattamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing issue with "role: back end/devOps" wasn't move to the "Done" column.

@t-will-gillis
Copy link
Member Author

t-will-gillis commented Sep 28, 2023

Hi @aramattamara Thanks for your comment!

FYI Looking at your "Action" logs, I believe that you need to update .github/workflows/move-closed-issues.yaml for:

Line 10: change to '@v4', e.g. uses: actions/checkout@v4
Line 24: change to reference your token, e.g. token: ${{ secrets.TEST_TOKEN }}

Otherwise, it looks like you have everything set up correctly so I think these are the only edits needed.

(In case you are wondering, both issues are being sorted to the "QA" column for a different reason than this action.)

@aramattamara aramattamara self-requested a review September 28, 2023 04:41
Copy link
Member

@aramattamara aramattamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rechecked the 'Token' variable, and everything is working perfectly
✅ Looks good to me. Nice work @t-will-gillis

@mademarc
Copy link
Member

Review ETA: 9/28/2023
Availability: 7:05PM

Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis the changes on line 10 on the yaml file are done correctly so great job on this.

@liamtirney liamtirney removed their request for review September 30, 2023 04:30
@t-will-gillis t-will-gillis merged commit c3e3387 into hackforla:gh-pages Oct 1, 2023
@t-will-gillis t-will-gillis deleted the dependabot-update-5492 branch October 1, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Draft Issue is still in the process of being created Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm dependabot version update to move-closed-issues.yml
3 participants