-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multiple GHAs about PRs #5575
Update multiple GHAs about PRs #5575
Conversation
Dependabot update `actions/checkout@v3` --> `@v4`
Dependabot update `actions/checkout@v3` --> `@v4`
Dependabot update `actions/checkout@v3` --> `@v4`
Dependabot update `actions/checkout@v3` --> `@v4`
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: Fri 9/29, 6pm |
Review ETA: 9/28/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @t-will-gillis good job on the changes on lines 13, 19, 43 on the yml files on this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @t-will-gillis — the branching is set up correctly, the corresponding issue is linked, the PR is descriptive, and the change updating the dependabot version from 3 to 4 across 4 files has been done correctly. Well done!
Fixes #5493
includes #5496
includes #5498
includes #5499
What changes did you make?
actions/checkout@v3
-->actions/checkout@v4
pr-instructions.yml
set-pr-labels.yaml
wr-pr-instructions.yml
wr-set-pr-labels.yaml
Why did you make the changes (we will use this info to test)?
Links to tests
Test PR
pr-instructions.yml log
set-pr-labels.yaml log
wr-pr-instructions.yml log
wr-set-pr-labels.yaml log
Note to PR Reviewers
The process for testing GHAs is different from procedures described in the
CONTRIBUTING.md
document. You will want to have an environment set up in your local repo and test the GHAs on the desktop.First, review the following wiki pages Hack for LA's GitHub Actions and follow the "Mini Guide".
To continue creating your testing environment, go to your local repo on the desktop and create a new branch for testing:
For testing this specific action you will need to make changes to four yml/yaml files:
.github/workflows/pr-instructions.yml
:- 'my-test-branch'
- uses: actions/checkout@v4
.github/workflows/set-pr-labels.yaml
:- 'my-test-branch'
- uses: actions/checkout@v4
.github/workflows/wr-pr-instructions.yml
:- uses: actions/checkout@v4
.github/workflows/wr-set-pr-labels.yaml
:- uses: actions/checkout@v4
Additional steps needed to successfully test this action:
CONTRIBUTING.md
if you want.