Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Remove "good second issue" #5626

Closed
wants to merge 3 commits into from

Conversation

Utkarsh3128
Copy link

@Utkarsh3128 Utkarsh3128 commented Sep 28, 2023

Fixes #5617 & #5591

What changes did you make?

  • Remove "good second issue" from CONTRIBUTING.md Section 2.3.b and 2.3.c

Why did you make the changes (we will use this info to test)?

  • To eliminate confusion, since good second issues no longer exist.

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

@romainyvernes romainyvernes self-requested a review September 29, 2023 03:40
@romainyvernes
Copy link
Member

Availability: 8h
ETA: 9/28

Copy link
Member

@romainyvernes romainyvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The issue states that the line to remove is under section 2.3.c, but the one you removed is under 2.3.b. It would make sense to have both removed since "good second issues" no longer exist anywhere, but you want to make sure to remove the correct line as stated in the issue. Then, you can see if there isn't another issue that would have been specifically created to remove the same line under section 2.3.b. If that isn't the case, you can inquire with the issue's author to suggest that the line be removed from section 2.3.b as well.
  2. You updated the cspell.json file in this PR, but it is outside the scope of the issue that needs fixing. You should revert that file back to the way it was.
  3. You didn't provide the test link for reviewers to ensure the changes were correctly applied as stated next to the 4th checkbox within the issue's description. I would suggest you do the following to improve the description of your PR:

Lastly, it is usually good practice to name your branches with a short description that gives some insight into the issue that will be resolved within a branch. The contributing guidelines provide more details on this here: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue

I realize this may look like a lot of issues, but don't let it discourage you. I'm trying to provide as many details as possible for you to have everything you need to resolve this successfully on your own. Let me know if you have any questions and I'll be happy to help you out.

@Utkarsh3128
Copy link
Author

@romainyvernes Sir, I have made changes as per your request. If still there is any mistake, please guide me.

@ajb176
Copy link
Member

ajb176 commented Sep 29, 2023

Hi @Utkarsh3128,

As said in your other PR, you have to be a member of Hack for LA to work on an issue. You can find details on the Getting Started page. You will have to attend an on-boarding session, the next will be held on October 17th. If you have any questions about the procedure to join, feel free to reach out. Thank you for your interest.

@ajb176 ajb176 closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "good second issue" from CONTRIBUTING.md Section 2.3.c
3 participants